linux-kernel - Re: [PATCH] cgroup_clone: use pid of newly created task for new cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080612203719.GA20755@us.ibm.com>
Date:	Thu, 12 Jun 2008 15:37:19 -0500
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	"Serge E. Hallyn" <serue@...ibm.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...l.org>,
	Paul Menage <menage@...gle.com>, Dan Smith <danms@...ibm.com>
Subject: Re: [PATCH] cgroup_clone: use pid of newly created task for new
	cgroup

Quoting Serge E. Hallyn (serue@...ibm.com):
> cgroup_clone creates a new cgroup with the pid of the task.  This works
> correctly for unshare, but for clone cgroup_clone is called from
> copy_namespaces inside copy_process, which happens before the new pid
> is created.  As a result, the new cgroup was created with current's pid.
> This patch:

"I swear it worked yesterday..."  but in any case this fix is needed on
top of the cgroup_clone patch

-serge

>From 8819a1f0e4e5ae9950b8310144b3fda2c30cab08 Mon Sep 17 00:00:00 2001
From: Serge Hallyn <serge@...ibm.com>
Date: Thu, 12 Jun 2008 15:33:38 -0500
Subject: [PATCH] ns_cgroup: include proc_fs.h

Need proc_fs.h included to slurp the PROC_NUMBUF #define.

Signed-off-by: Serge Hallyn <serge@...ibm.com>
---
 kernel/ns_cgroup.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/ns_cgroup.c b/kernel/ns_cgroup.c
index 6431fb7..d6895d0 100644
--- a/kernel/ns_cgroup.c
+++ b/kernel/ns_cgroup.c
@@ -9,6 +9,7 @@
 #include <linux/fs.h>
 #include <linux/slab.h>
 #include <linux/nsproxy.h>
+#include <linux/proc_fs.h>
 
 struct ns_cgroup {
 	struct cgroup_subsys_state css;
-- 
1.5.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/