linux-kernel - Re: [PATCH 2/5] futex: update prio on requeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1213248163.31518.73.camel@twins>
Date:	Thu, 12 Jun 2008 07:22:43 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	linux-kernel@...r.kernel.org, Ulrich Drepper <drepper@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH 2/5] futex: update prio on requeue

On Wed, 2008-06-11 at 13:49 -0700, Daniel Walker wrote:
> plain text document attachment (futex-update-prio-on-requeue.patch)
> Since the priority may have changed, the requeue is a good place to update
> the priority since we're already deleting and adding to a new list.
> 
> Signed-off-by: Daniel Walker <dwalker@...sta.com>
> 
> ---
>  kernel/futex.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> Index: linux-2.6.25/kernel/futex.c
> ===================================================================
> --- linux-2.6.25.orig/kernel/futex.c
> +++ linux-2.6.25/kernel/futex.c
> @@ -980,7 +980,10 @@ static int futex_requeue(u32 __user *uad
>  			 * requeue.
>  			 */
>  			if (likely(head1 != &hb2->chain)) {
> +				struct task_struct *task = this->task;
> +				int prio = min(task->normal_prio, MAX_RT_PRIO);

we want whitespace between var declarations and code

>  				plist_del(&this->list, &hb1->chain);
> +				plist_node_init(&this->list, prio);
>  				plist_add(&this->list, &hb2->chain);
>  				this->lock_ptr = &hb2->lock;
>  #ifdef CONFIG_DEBUG_PI_LIST
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/