linux-kernel - Re: [patch 3/6] x86: use cpuinfo to check for interrupt pending message msr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0806131436510.5735@apollo.tec.linutronix.de>
Date:	Fri, 13 Jun 2008 14:38:30 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andreas Herrmann <andreas.herrmann3@....com>
cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Arjan van de Veen <arjan@...radead.org>
Subject: Re: [patch 3/6] x86: use cpuinfo to check for interrupt pending
 message msr

On Fri, 13 Jun 2008, Andreas Herrmann wrote:
> > +	/* Family 0x0f models < rev F do not have this MSR */
> > +	if (c->x86 == 0x0f && c->x86_model < 0x40)
> > +		return 0;
> 
> Just some minor nitpicking.
> Older AMD family 0xf CPUs have this Interrupt Pending Message
> Register. But they do not support C1E and thus bits 27 and 28 of this
> MSR are reserved.

So the check can be simplified to always check the MSR for all 
family >= 0x0f CPUs ?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/