linux-kernel - [RFC][PATCH] kmemcheck: divide and conquer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080613140057.GA25833@damson.getinternet.no>
Date:	Fri, 13 Jun 2008 16:00:57 +0200
From:	Vegard Nossum <vegard.nossum@...il.com>
To:	Pekka Enberg <penberg@...helsinki.fi>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org
Subject: [RFC][PATCH] kmemcheck: divide and conquer

Hi,

I've split the main x86/mm/kmemcheck.c file and made a subdirectory of many
files instead.

I have included the diffstat below, but I think the patch itself is too big
for the mailing list. It can instead be viewed at:

http://www.kernel.org/pub/linux/kernel/people/vegard/patches/0001-kmemcheck-divide-and-conquer.patch

The RFC part: Is this a good thing to do? I personally hate the 4000-line
files that are so commonly found in the kernel, and therefore prefer this
split-up. On the other hand, C lacks namespaces, which sometimes leads to
some really long and ugly names just to prevent clashes in the future. But
it's your call, I'll just do whatever it takes to get in... ;-)


Vegard


Author: Vegard Nossum <vegard.nossum@...il.com>
Date:   Wed Jun 11 12:37:13 2008 +0200

    kmemcheck: divide and conquer

    This patch splits the kmemcheck.c into a subdirectory of many files. This
    makes it easier to get around the different functions because they're now
    grouped together by file.

    Signed-off-by: Vegard Nossum <vegard.nossum@...il.com>

 arch/x86/mm/Makefile              |    2 +-
 arch/x86/mm/kmemcheck.c           | 1100 -------------------------------------
 arch/x86/mm/kmemcheck/Makefile    |    3 +
 arch/x86/mm/kmemcheck/error.c     |  215 ++++++++
 arch/x86/mm/kmemcheck/error.h     |   15 +
 arch/x86/mm/kmemcheck/kmemcheck.c |  477 ++++++++++++++++
 arch/x86/mm/kmemcheck/opcode.c    |   70 +++
 arch/x86/mm/kmemcheck/opcode.h    |    9 +
 arch/x86/mm/kmemcheck/pte.c       |   22 +
 arch/x86/mm/kmemcheck/pte.h       |   10 +
 arch/x86/mm/kmemcheck/shadow.c    |  174 ++++++
 arch/x86/mm/kmemcheck/shadow.h    |   16 +
 arch/x86/mm/kmemcheck/smp.c       |   79 +++
 arch/x86/mm/kmemcheck/smp.h       |   23 +
 arch/x86/mm/kmemcheck/string.c    |   91 +++
 include/linux/kmemcheck.h         |    3 +
 16 files changed, 1208 insertions(+), 1101 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/