[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080613153635.GY11300@solarflare.com>
Date: Fri, 13 Jun 2008 16:36:37 +0100
From: Ben Hutchings <bhutchings@...arflare.com>
To: Ingo Molnar <mingo@...e.hu>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org,
Vegard Nossum <vegard.nossum@...il.com>
Subject: Re: [PATCH] cputopology: Always define CPU topology information [5th try]
Ingo Molnar wrote:
>
> * Ben Hutchings <bhutchings@...arflare.com> wrote:
>
> > > > This patch:
> > > >
> > > > - Adds default definitions of the 4 topology macros to <linux/topology.h>
> > > > - Changes drivers/base/topology.c to use the topology macros unconditionally
> > > > - Updates documentation accordingly
> > >
> > > applied to tip/core/topology - thanks Ben.
> >
> > Unfortunately you lost the first paragraph of the commit message, then
> > created a second commit (difference between 4th and 5th versions) with
> > your own commit message and me as the author. Maybe it's nitpicking
> > but I would prefer to have strictly accurate metadata in the commit
> > log.
>
> that's OK, see the delta patch below, it's rather trivial. It's better
> to do these small delta patches where each change stands on its own than
> to review a more complex combo patch. (Suggest me any other commit
> metadata for this delta if you prefer, we can still change it.)
[...]
The message should be:
Revert first two hunks of "cputopology: Always define CPU topology information"
which were redundant with "x86: cleanup early per cpu variables/accesses v4".
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists