linux-kernel - [PATCH 0/2] PCI 2.1 VPD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080613212743.GZ11300@solarflare.com>
Date:	Fri, 13 Jun 2008 22:27:44 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jesse Barnes <jbarnes@...tuousgeek.org>
Cc:	Matthew Wilcox <matthew@....cx>, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: [PATCH 0/2] PCI 2.1 VPD support

PCI 2.1 specifies a way to provide VPD in the expansion ROM.  This patch
series exposes that in the same way as PCI 2.2 VPD.

I do not have any production devices with VPD in ROM so I reflashed a NIC
with an image including it.  This code should be tested against some
production ROMs since I may have misinterpreted the specification both
when reading and writing!

There are two remaining aspects of this that I'm not quite happy about:

1. I understand that the expansion ROM may share a decoder with BAR 0,
which makes expansion ROM access dangerous when a driver is loaded.  The
sysfs "rom" attribute must be specifically read-enabled by writing to it,
which I assume is intended to protect against this.  Perhaps
pci_vpd_pci21_read() should test pdev->rom_attr_enabled?

2. PCI resource allocation may fail during pci_scan_device() and
therefore I could not insert the call to pci_vpd_pci21_init() there.
Instead I added it to pci_create_sysfs_dev_files() - but I don't really
think this function should be probing.  Is there a better place to add
the call?

Ben.

Ben Hutchings (2):
  PCI: ROM access changes to support PCI 2.1 VPD
  PCI: Expose PCI 2.1 VPD through sysfs

 drivers/pci/pci-sysfs.c |    2 +-
 drivers/pci/pci.h       |    1 +
 drivers/pci/rom.c       |  245 +++++++++++++++++++++++++++++++++++++++--------
 3 files changed, 206 insertions(+), 42 deletions(-)

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/