[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080614175723.209e93dc@mjolnir.drzeus.cx>
Date: Sat, 14 Jun 2008 17:57:23 +0200
From: Pierre Ossman <drzeus-mmc@...eus.cx>
To: Anton Vorontsov <avorontsov@...mvista.com>
Cc: David Brownell <dbrownell@...rs.sourceforge.net>,
Grant Likely <grant.likely@...retlab.ca>,
Jochen Friedrich <jochen@...am.de>,
Segher Boessenkool <segher@...nel.crashing.org>,
Gary Jennejohn <garyj@...x.de>,
Guennadi Liakhovetski <g.liakhovetski@....de>,
linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi
driver
On Thu, 5 Jun 2008 20:16:24 +0400
Anton Vorontsov <avorontsov@...mvista.com> wrote:
> Here is v3. I'm out of ideas if you won't like it. :-)
>
> v3:
> - Now these bindings are using bus notifiers chain, thus we adhere to the
> spi bus.
>
Now this was nice and clean. I take it Grant doesn't like this version
though. What's the downside of it?
>
> - Plus changed the OF bindings themselves, implemented voltage-range
> property. (Pierre, please take a look at vddrange_to_ocrmask(). I
> wonder if you would like this in the MMC core instead, with a kernel
> doc, of course.)
>
That might be a good idea in the long run. MMC OCR masks have some
gotchas, so it's best if we have as few pieces of code as possible
dealing with it.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the
Swedish government. Use end-to-end encryption where
possible.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists