linux-kernel - Re: [PATCH] x86: cleanup reloated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48541E7B.7020002@zytor.com>
Date:	Sat, 14 Jun 2008 12:39:39 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yhlu.kernel@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: cleanup reloated_initrd

Yinghai Lu wrote:
  Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>
>>>
>>> Index: linux-2.6/arch/x86/kernel/setup_32.c
>>> ===================================================================
>>> --- linux-2.6.orig/arch/x86/kernel/setup_32.c
>>> +++ linux-2.6/arch/x86/kernel/setup_32.c
>>> @@ -585,6 +585,9 @@ static void __init relocate_initrd(void)
>>>        printk(KERN_INFO "Copied RAMDISK from %016llx - %016llx to %08llx -
>>> %08llx\n",
>>>                ramdisk_image, ramdisk_image + ramdisk_size - 1,
>>>                ramdisk_here, ramdisk_here + ramdisk_size - 1);
>>> +
>>> +       /* need to free that, otherwise init highmem will reserve it again
>>> */
>>> +       free_early(ramdisk_image, ramdisk_image+ramdisk_size);
>>>  }
>>>
>> I'm somewhat confused by this... you realize that the old location and the
>> new location of the initrd will overlap, right?
> 
> Ying Huang add page_is_reserved_early check in
> add_one_highpage_init(), so reserve_early high address will be
> reserved when in init high. that is not wanted old initrd in high
> region we will lose some ram
> 

Yes, but I think the above will free part of the active area if the 
areas overlap.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/