linux-kernel - Re: [PATCH] x86: use add_highpages_with_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080614085933.GA1649@elte.hu>
Date:	Sat, 14 Jun 2008 10:59:33 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ying Huang <ying.huang@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: use add_highpages_with_active_regions for high
	pages init


* Ingo Molnar <mingo@...e.hu> wrote:

> > Andrew: mm/page_alloc.c modification.
> 
> i ended up doing the change below.
> 
> 'bad_ppro' looked quite ugly in mm/page_alloc.c, and there was also a 
> 64-bit build failure, so i moved the function out of page_alloc.c, 
> into the 32-bit x86 code.

hm, this doesnt work very well with non-NUMA 32-bit highmem configs as 
the attached one. There no for_each_active_range_index_in_nid(), etc. 
Might make sense to provide obvious definitions for these NUMA functions 
for the non-numa case too?

	Ingo

View attachment "config" of type "text/plain" (19772 bytes)