linux-kernel - Re: [PATCH 2/2] 8139too: different style cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4854B604.6080900@davidnewall.com>
Date:	Sun, 15 Jun 2008 15:56:12 +0930
From:	David Newall <davidn@...idnewall.com>
To:	Németh Márton <nm127@...email.hu>
CC:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	Trivial Patch Monkey <trivial@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] 8139too: different style cleanups

Németh Márton wrote:
>  #  define DPRINTK(fmt, args...) \
> -	printk(KERN_DEBUG "%s: " fmt, __FUNCTION__ , ## args)
> +	printk(KERN_DEBUG "%s: " fmt, __func__ , ## args)
>   

Why change __FUNCTION__ to __func__?  I don't even know where __func__
come from?  Assuming that it isn't totally broken, and I'll believe that
it isn't, then would it be compiler-specific?   __FUNCTION__ is standard
and that's more than enough reason to prefer that form to any
non-standard variation.


Yes to the following; no to all the rest:

> -#define RTL8139_CAPS	HAS_CHIP_XCVR|HAS_LNK_CHNG
> +#define RTL8139_CAPS	(HAS_CHIP_XCVR|HAS_LNK_CHNG)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/