linux-kernel - Re: [PATCH] debugobjects: fix lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19f34abd0806150446s35ed1ffib9a7ab459f00e870@mail.gmail.com>
Date:	Sun, 15 Jun 2008 13:46:21 +0200
From:	"Vegard Nossum" <vegard.nossum@...il.com>
To:	"Daniel J Blueman" <daniel.blueman@...il.com>
Cc:	"Thomas Gleixner" <tglx@...utronix.de>,
	"Christoph Lameter" <clameter@....com>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Pekka Enberg" <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] debugobjects: fix lockdep warning

On Sun, Jun 15, 2008 at 11:52 AM, Daniel J Blueman
<daniel.blueman@...il.com> wrote:
> On Sat, Jun 14, 2008 at 11:58 PM, Vegard Nossum <vegard.nossum@...il.com> wrote:
>> Hi,
>>
>> I don't know whether this is truly the Right Fix; if it isn't, feel free
>> to re-use my commit template for when the RF appears... ;-)
>>
>> Daniel, is there any chance you can try it out? Thanks.
>
> I get a warning [1] about pool-lock being IRQ-unsafe as-is.
> Additionally promoting pool_lock to be IRQ-safe [2] resolves the
> issue, but this may not be desired. Ping me for further tests and
> thanks!

Ah, yes. Thanks for testing! I thought it might introduce some other
badness. I can't really comment on your new changes (I am not sure
what the implications are exactly), but if it fixes the regression,
then it sounds correct :-)

(I also think this needs Thomas's SOB rather than mine. I am not sure
he's fine with kicking out the retry code :-P)


Vegard

-- 
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
	-- E. W. Dijkstra, EWD1036
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/