linux-kernel - Re: [PATCH 06/10] HID: move logitech report quirks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0806161214130.10085@jikos.suse.cz>
Date:	Mon, 16 Jun 2008 12:15:39 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jiri Slaby <jirislaby@...il.com>
cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, marcel@...tmann.org,
	linux-kernel@...r.kernel.org, anssi.hannula@...il.com
Subject: Re: [PATCH 06/10] HID: move logitech report quirks

On Mon, 9 Jun 2008, Jiri Slaby wrote:

> > > Move them from core code to a separate driver.
> > is there a reason why this moves only the report descriptor 
> > Logitech-specific quirks, but leaves the input mapping still in 
> > hid-input-quirks.c and doesn't move it into ->input_mapping method 
> > too?
> No, there is no strong reason, I just postponed it to the second round of
> changes. I wanted to hear comments first, so I only moved fully only apple
> driver (to present how the concept was thought). After things settle down, I'm
> going to move the rest of quirks including this one.

Thanks a lot. Would you please care to do another round of submission, 
with the missing assignment fixed in the apple driver, and also with the 
->input_mapping added too?

I would like to avoid a situation when we have a part of functionality for 
certain devices implemented in generic driver and a part in specialized 
driver, if possible.

Thanks a lot,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/