linux-kernel - Re: [Patch 002/005](memory hotplug) align memmap to page size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080616211035.9EA1.E1E9C6FF@jp.fujitsu.com>
Date:	Mon, 16 Jun 2008 22:26:29 +0900
From:	Yasunori Goto <y-goto@...fujitsu.com>
To:	Andy Whitcroft <apw@...dowen.org>
Cc:	Badari Pulavarty <pbadari@...ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel ML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>, Yinghai Lu <yhlu.kernel@...il.com>
Subject: Re: [Patch 002/005](memory hotplug) align memmap to page size

> On Mon, Apr 07, 2008 at 09:46:19PM +0900, Yasunori Goto wrote:
> > To free memmap easier, this patch aligns it to page size.
> > Bootmem allocater may mix some objects in one pages.
> > It's not good for freeing memmap of memory hot-remove.
> > 
> > 
> > Signed-off-by: Yasunori Goto <y-goto@...fujitsu.com>
> > 
> > ---
> >  mm/sparse.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > Index: current/mm/sparse.c
> > ===================================================================
> > --- current.orig/mm/sparse.c	2008-04-07 19:18:50.000000000 +0900
> > +++ current/mm/sparse.c	2008-04-07 20:08:13.000000000 +0900
> > @@ -265,8 +265,8 @@
> >  	if (map)
> >  		return map;
> >  
> > -	map = alloc_bootmem_node(NODE_DATA(nid),
> > -			sizeof(struct page) * PAGES_PER_SECTION);
> > +	map = alloc_bootmem_pages_node(NODE_DATA(nid),
> > +		       PAGE_ALIGN(sizeof(struct page) * PAGES_PER_SECTION));
> >  	return map;
> >  }
> >  #endif /* !CONFIG_SPARSEMEM_VMEMMAP */
> 
> Ahh ok, we do makes sure the mmap uses up the rest of the space.  That
> though is a shame as we cannot slip the usemap in the end of the space
> any more (assuming we could).

I thought we could merge memmap and usemap page in same pages. However,
if memmap' size equals page size correctly, one page must be used for
only one usemap in the end. 

Bye.

-- 
Yasunori Goto 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/