linux-kernel - Re: [PATCH] ip2: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4856C6C8.6060506@garzik.org>
Date:	Mon, 16 Jun 2008 16:02:16 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, jaswinder@...radead.org
Subject: Re: [PATCH] ip2: use request_firmware()

Alan Cox wrote:
> On Mon, 16 Jun 2008 10:49:11 +0100
> David Woodhouse <dwmw2@...radead.org> wrote:
> 
>> Converted with help from Jaswinder Singh
>>
>> Signed-off-by: David Woodhouse <dwmw2@...radead.org>
>> ---
>>  drivers/char/Kconfig           |    7 +
>>  drivers/char/ip2/fip_firm.h    | 2149 ----------------------------------------
>>  drivers/char/ip2/ip2base.c     |    5 +-
>>  drivers/char/ip2/ip2main.c     |   45 +-
>>  firmware/Makefile              |    1 +
>>  firmware/WHENCE                |   10 +
>>  firmware/intelliport2.bin.ihex | 2147 +++++++++++++++++++++++++++++++++++++++
>>  7 files changed, 2201 insertions(+), 2163 deletions(-)
>>  delete mode 100644 drivers/char/ip2/fip_firm.h
>>  create mode 100644 firmware/intelliport2.bin.ihex
> 
> Fine by me. I've not checked all the digits are correct but the rest of
> the logic seems clean enough
> 
> Acked-by: Alan Cox <alan@...hat.com>

Except for the part where the firmware is pointlessly separated from the 
driver.

We do not need two parallel driver hierarchies, one for firmware, one 
for C source.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/