linux-kernel - Re: [PATCH] ip2: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080616205638.2e9930fe@lxorguk.ukuu.org.uk>
Date:	Mon, 16 Jun 2008 20:56:38 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, jaswinder@...radead.org
Subject: Re: [PATCH] ip2: use request_firmware()

> > Acked-by: Alan Cox <alan@...hat.com>
> 
> Except for the part where the firmware is pointlessly separated from the 
> driver.
> 
> We do not need two parallel driver hierarchies, one for firmware, one 
> for C source.

It makes enormous sense to me that we split them up. I don't care about
or believe the gnewspeak about licensing some people spew on the issue
but as a simple practical consideration:

- I don't want to wade through a ton of hex when looking at the driver
- I don't gain anything but having a ton of hex in the driver files
- I'd rather the ip2 firmware was ultimately loaded and unloaded when
needed as it saves us a load of non-pageable RAM.
- The firmware is a separate piece of software run on a separate CPU on a
seperate box on a separate card.

So from purely technical perspectives I think the patch is a very good
one, and as the nearest thing we have to a serial maintainer it gets my
ack. The only thing they share is an agreed API over the ISA/PCI bus -
and that isn't defined by peering at the firmware image.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/