linux-kernel - Re: [PATCH] x86: make asm/asm.h work for asm code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4856ECC0.3050201@kernel.org>
Date:	Mon, 16 Jun 2008 15:44:16 -0700
From:	"H. Peter Anvin" <hpa@...nel.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	the arch/x86 maintainers <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: make asm/asm.h work for asm code.

Jeremy Fitzhardinge wrote:

> +# define __ASM_INC    incl
> +# define __ASM_INC    incq
> +#define _ASM_INC    __ASM_INC
> +#define _ASM_INC    " " __stringify(__ASM_INC) " "

You have *exactly* as many #defines as if one would simply do four cases 
(32 C, 64 C, 32 asm, 64 asm), and that would be easier to read...

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/