linux-kernel - Re: sync_file_range(SYNC_FILE_RANGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080617093825.7a245f7f@bree.surriel.com>
Date:	Tue, 17 Jun 2008 09:38:25 -0400
From:	Rik van Riel <riel@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Hugh Dickins <hugh@...itas.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	Lee Schermerhorn <lee.schermerhorn@...com>,
	Pavel Machek <pavel@...e.cz>, mtk.manpages@...il.com,
	kernel list <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: sync_file_range(SYNC_FILE_RANGE_WRITE) blocks?

On Mon, 16 Jun 2008 21:54:06 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> > The problem with lots of CFQ requests is simpler.
> > 
> > If you look at balance_dirty_pages() you will see that it only
> > takes dirty and NFS unstable pages into account when checking
> > the dirty limit.  The pages that are in flight (under IO) are
> > not counted at all.
> 
> That would be totally busted.  All that nr_writeback logic in there is very
> much supposed to handle under-writeback pages?

Mmm, you are right.   It is counting the number of writeback
pages.

It just isn't waiting on them.  After moving enough pages from
dirty state to writeback state, it breaks out of the loop and
allows memory dirtying to continue.

                if (pages_written >= write_chunk)
                        break;          /* We've done our duty */

I wonder if we should wait for some IO to complete, or at least
do a simple congestion_wait() if the number of writeback pages
is very large?

-- 
All rights reversed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/