linux-kernel - Re: [PATCH] x86: merge setup_memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86802c440806170918l1cb10014nccfd8d3e2b13da47@mail.gmail.com>
Date:	Tue, 17 Jun 2008 09:18:01 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	"Glauber Costa" <glommer@...il.com>, "Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: merge setup_memory_map with e820

On Tue, Jun 17, 2008 at 9:04 AM, H. Peter Anvin <hpa@...or.com> wrote:
> Glauber Costa wrote:
>>>
>>> +       boot_params.e820_entries = new_nr;
>>> +       if (copy_e820_map(boot_params.e820_map, boot_params.e820_entries)
>>> < 0) {
>>> +#ifdef CONFIG_X86_64
>>> +               early_panic("Cannot find a valid memory map");
>>> +#else
>>
>> Can't this be made dependant on HIGHMEM instead of X86_64? It seems
>> high-memory dependant anyway. Also, are you sure
>> this code that maps into himem would work with HIGHMEM disabled anyway?

that is behavoir before merge.

>>
>
> Uhm... x86-64 and HIGHMEM are mutually exclusive.
>
> Either way, it shouldn't be dependent on anything; there is no reason why
> the #else clause can't be applied to both.

remove the early_panic?

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/