linux-kernel - [PATCH] suppress needless timer reprogramming {tick-sched.c}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <13B9B4C6EF24D648824FF11BE8967162035B8F807C@dlee02.ent.ti.com>
Date:	Mon, 16 Jun 2008 19:05:47 -0500
From:	"Woodruff, Richard" <r-woodruff2@...com>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	Tony Lindgren <tony@...mide.com>,
	David Brownell <david-b@...bell.net>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>
Subject: [PATCH] suppress needless timer reprogramming {tick-sched.c}

Thomas,

Does this patch look ok?

It simply does a check to see if the about to be reprogrammed 1 shot already is the last event programmed in the hardware.  If it is it skips calling the hardware.

In my device I get many interrupts from a high speed USB device in a very short period of time.  The system spends a lot of time reprogramming the hardware timer which is in a slower timing domain as compared to the CPU.  This results in the CPU spending a huge amount of time waiting for the timer posting to be done.  All of this reprogramming is useless as the wake up time has not changed.

As measured using ETM trace this drops my reprogramming penalty from almost 60% CPU load down to 15% during high interrupt rate.  If you like I can send traces to show this.

Regards,
Richard W.

BTW:
I can much the other 15% by keeping the ticker on by using a function like there is for rcu today in tick-sched.c. Something like an irq_needs_cpu() by the rcu_needs_cpu() check.  Where return = 1 if (curr_irq_ts - last_irq_ts < min_delta_ns).  A time stamp is taken in irq code at entry.

Download attachment "suppress_reprogram_2626-rc5.diff" of type "application/octet-stream" (1454 bytes)