linux-kernel - Re: [patch 06/15] MMC: Add platform data for S3C24XX MMC/SD driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080617232033.GD10351@trinity.fluff.org>
Date:	Wed, 18 Jun 2008 00:20:33 +0100
From:	Ben Dooks <ben-linux@...ff.org>
To:	Pierre Ossman <drzeus@...eus.cx>
Cc:	Ben Dooks <ben-linux@...ff.org>, linux-kernel@...r.kernel.org,
	Harald Welte <laforge@...nmoko.org>,
	Thomas Kleffel <tk@...ntech.de>,
	Roman Moravcik <roman.moravcik@...il.com>
Subject: Re: [patch 06/15] MMC: Add platform data for S3C24XX MMC/SD driver

On Sat, Jun 14, 2008 at 06:22:20PM +0200, Pierre Ossman wrote:
> On Fri, 06 Jun 2008 16:51:23 +0100
> Ben Dooks <ben-linux@...ff.org> wrote:
> 
> > This patch adds platform data support to the s3mci driver.  This allows
> > flexible board-specific configuration of set_power, card detect and read only
> > pins.
> > 
> > Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> > 
> 
> Please see the changes in my #next branch where you can return -ENOSYS
> to indicate that you do not know the state of the read only pin.

thanks, fixed.
 
> > +
> > +static struct s3c24xx_mci_pdata s3cmci_def_pdata = {
> > +	.gpio_detect	= 0,
> > +	.set_power	= NULL,
> > +	.ocr_avail	= MMC_VDD_32_33,
> >  };
> 
> You probably want MMC_VDD_32_32 | MMC_VDD_33_34 here.

Ok, updated.

thanks,
-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/