| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Jun 2008 09:34:44 +0200 From: Markus Armbruster <armbru@...hat.com> To: "Jaya Kumar" <jayakumar.lkml@...il.com> Cc: "Jeremy Fitzhardinge" <jeremy@...p.org>, "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org> Subject: Re: "fb-defio: fix page list with concurrent processes" "Jaya Kumar" <jayakumar.lkml@...il.com> writes: > On Mon, Jun 16, 2008 at 3:05 PM, Jeremy Fitzhardinge <jeremy@...p.org> wrote: >> Your patch "fb-defio: fix page list with concurrent processes" definitely >> seems to help with the suspend/resume problem I had with the Xen pvfb >> device. Is it queued up anywhere? It seems to be a real bugfix, and should >> probably be queued for 2.6.26... > > It isn't currently queued. I had intended to improve its performance > by taking advantage of Andrew's suggestion of using !list_empty on the > page->lru to avoid walking the page list to find the duplicate page, > but I ran into trouble since the page starts off being on the lru > list. I'll try to take a look at doing this next weekend. > > Thanks, > jaya Well, we got a bug that makes the code useless in practice for us, and a fix for it that's not quite as fast as it could be. Which is better, somewhat slow code, or somewhat useless code? I'd like to see the fix merged as soon as possible. You can always improve its performance later. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists