linux-kernel - Re: 2.6.25.3: serial problem (minicom)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080617095827.0f4f77de@lxorguk.ukuu.org.uk>
Date:	Tue, 17 Jun 2008 09:58:27 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"R.L. Horn" <lists@...tcheap.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: 2.6.25.3: serial problem (minicom)

On Mon, 16 Jun 2008 23:22:54 -0500 (CDT)
"R.L. Horn" <lists@...tcheap.org> wrote:

> On Mon, 16 Jun 2008, Alan Cox wrote:
> 
> > Whatever it implies the behaviour should not have changed between 2.6.24
> > and 2.6.25. Nobody AFAIK sat down and decided to change it.
> 
> And, besides, I've gotten reports that the usb-serial drivers still behave 
> the same as with 2.6.24.
> 
> It looks like the call to tty_termios_encode_baud_rate() in 
> drivers/serial/8250.c is the culprit.  If I comment it out, everything 
> appears to go back to normal (seemingly with no undesired side effects).
> 
> Why the call is there (it didn't replace anything else in the 2.6.24.7 
> version of 8250.c, though it did in serial_core.c) remains a mystery to 
> me.

Ah ok I know what the bug is - it was fixed in 2.6.26-rc as follows

+       /* Don't rewrite B0 */
+       if (tty_termios_baud_rate(termios))
+               tty_termios_encode_baud_rate(termios, baud, baud);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/