| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4859223A.50700@s5r6.in-berlin.de> Date: Wed, 18 Jun 2008 16:56:58 +0200 From: Stefan Richter <stefanr@...6.in-berlin.de> To: Paolo Ciarrocchi <paolo.ciarrocchi@...il.com> CC: Dmitri Vorobiev <dmitri.vorobiev@...ial.fi>, Ingo Molnar <mingo@...e.hu>, tglx <tglx@...utronix.de>, hpa <hpa@...or.com>, Linux Kernel <linux-kernel@...r.kernel.org>, Andy Whitcroft <apw@...dowen.org> Subject: Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg_constant > On Wed, Jun 18, 2008 at 3:09 PM, Dmitri Vorobiev > <dmitri.vorobiev@...ial.fi> wrote: >> Paolo Ciarrocchi wrote: >>> >>> -static void fld_const(FPU_REG const *c, int adj, u_char tag) >>> +static void fld_const(FPU_REG const * c, int adj, u_char tag) >> ________________________________________^ >> >> The above does not seem to me like a big improvement in code quality. A >> false positive from checkpatch.pl? It should obviously be static void fld_const(const FPU_REG *c, int adj, u_char tag) FPU_REG is not an appropriate type name though. Is "typedef struct fpu__reg FPU_REG;" necessary at all? (Removing it would create some code churn all over x86/math-emu/ though. Maybe not desirable.) -- Stefan Richter -=====-==--- -==- =--=- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists