[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <48598784.40306@e-teleport.net>
Date: Thu, 19 Jun 2008 00:09:08 +0200
From: Séguier Régis <rseguier@...eleport.net>
To: Francois Romieu <romieu@...zoreil.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Arjan van de Ven <arjan@...radead.org>, alan@...hat.com,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: via-velocity.c fix sleep-with-spinlock bug during
MTU change
Francois Romieu a écrit :
> Séguier Régis <rseguier@...eleport.net> :
> [...]
>
>> This correction seems to work.
>>
>> I read somewhere pci_free_consistent (in velocity_free_dma_rings) couldn't
>> be use in a spin_lock.
>>
>
> Yup.
>
>
>> When I move velocity_free_rings outside the spin_lock, error desappeare but
>> data transfert doesn't work after the mtu change.
>> When I add velocity_give_many_rx_descs all work.
>>
>
> I have updated http://userweb.kernel.org/~romieu/via-velocity/2.6.26-rc6/
> accordingly. Can you check whether it is fine or not ?
>
>
Patch 0001 doesn't work,
if I don't make a mistake skb->len is not modified in skb_pad{,to}when
the padding is applied. In this case, we need to attribute ETH_ZLEN to len.
--
Régis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists