linux-kernel - Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Jun 2008 12:19:27 +0300
From:	Dmitri Vorobiev <dmitri.vorobiev@...ial.fi>
To:	Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>,
	Ingo Molnar <mingo@...e.hu>
CC:	Andy Whitcroft <apw@...dowen.org>, tglx <tglx@...utronix.de>,
	hpa <hpa@...or.com>, Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: coding style fixes to arch/x86/math-emu/reg_constant

Andy Whitcroft wrote:
> On Wed, Jun 18, 2008 at 04:19:38PM +0200, Paolo Ciarrocchi wrote:
>> On Wed, Jun 18, 2008 at 3:09 PM, Dmitri Vorobiev
>> <dmitri.vorobiev@...ial.fi> wrote:
>>> Paolo Ciarrocchi wrote:
>>>> -static void fld_const(FPU_REG const *c, int adj, u_char tag)
>>>> +static void fld_const(FPU_REG const * c, int adj, u_char tag)
>>> ________________________________________^
>>>
>>> The above does not seem to me like a big improvement in code quality. A
>>> false positive from checkpatch.pl?
>> Yes, I think you are right.
>> Andy CC'ed so that he can have a look at that.
> 
> That would be a false positive if we are recommending that.  I have
> pushed this fragment in isolation through all versions back to 0.15 and
> none of them recommend it.
> 
> Ahh, but if I push the whole patch through 0.19 spits it out.  Ok this
> is a subtle bug in modifier procesing and is fixed in the head of my
> tree.  Will be fixed in the next batch which goes up to -mm.

Maybe it makes sense for Ingo to revert the original Paolo's patch now?

Dmitri

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/