linux-kernel - Re: [git pull] agp patches for 2.6.26 final

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.0.82.0806190557280.14089@skynet.skynet.ie>
Date:	Thu, 19 Jun 2008 06:01:42 +0100 (IST)
From:	Dave Airlie <airlied@...ux.ie>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [git pull] agp patches for 2.6.26 final

> On Thu, 19 Jun 2008, Dave Airlie wrote:
> > 
> > commit 62c96b9d0917894c164aa3e474a3ff3bca1554ae
> > Author: Dave Airlie <airlied@...hat.com>
> > Date:   Thu Jun 19 14:27:53 2008 +1000
> > 
> >     agp/intel: cleanup some serious whitespace badness
> >     
> >     Signed-off-by: Dave Airlie <airlied@...hat.com>
> 
> Aarghh!
> 
> This one does _not_ just clean up whitespace. It also does
> 
> 	@@ -1959,8 +1959,6 @@ static const struct agp_bridge_driver intel_i965_driver = {
> 	 	.size_type		= FIXED_APER_SIZE,
> 	 	.num_aperture_sizes	= 4,
> 	 	.needs_scratch_page	= true,
> 	-	.configure		= intel_i915_configure,
> 	-	.fetch_size		= intel_i9xx_fetch_size,
> 	 	.cleanup		= intel_i915_cleanup,
> 	 	.tlb_flush		= intel_i810_tlbflush,
> 	 	.mask_memory		= intel_i965_mask_memory,
> 
> which may well be all good, but it doesn't match the commit message.
> 
> I merged it, but please be more careful.
> 

DAMNIT.

I can't believe that happened, I going to stop doing whitespace cleanups 
now, I just got shocked when I realised how much 7 space indents that file 
has.

You are right please put back the two lines as per the attached patch.

Dave.
View attachment "test.patch" of type "TEXT/x-diff" (857 bytes)