linux-kernel - Re: [PATCH] Unify crashkernel reservation for 32 and 64 bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080620160223.4a0f1dd8@halley.suse.de>
Date:	Fri, 20 Jun 2008 16:02:23 +0200
From:	Bernhard Walle <bwalle@...e.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org, yhlu.kernel@...il.com
Subject: Re: [PATCH] Unify crashkernel reservation for 32 and 64 bit

* Ingo Molnar [2008-06-20 15:56]:
> * Bernhard Walle <bwalle@...e.de> wrote:
> 
> > This patch moves the reserve_crashkernel() to setup.c and removes the 
> > architecture-specific version. Both versions were more or less the 
> > same.
> 
> famous last words :)
> 
> can you see any functionality difference between them? If yes, that 
> should be declared.

The only difference was the calculation of memory -- it's more
complicated on i386 because of high memory support, so that was
outsourced to an inline function. However, because the highmem is in

  #ifdef CONFIG_HIGHMEM
  #endif

and CONFIG_HIGHMEM is off on x86-64, that doesn't matter. Do you see
another issue?

I tested it on both x86-64 and i386, with CONFIG_KEXEC on and off (so
that it compiles).



Bernhard
-- 
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/