[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <485BBC74.70505@linux.vnet.ibm.com>
Date: Fri, 20 Jun 2008 19:49:32 +0530
From: Balbir Singh <balbir@...ux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
CC: Li Zefan <lizf@...fujitsu.com>, Paul Menage <menage@...gle.com>,
LKML <linux-kernel@...r.kernel.org>,
Linux Containers <containers@...ts.linux-foundation.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Paul Jackson <pj@....com>
Subject: Re: [RFC] [PATCH] cgroup: add "procs" control file
KAMEZAWA Hiroyuki wrote:
> On Wed, 18 Jun 2008 16:02:25 +0800
> Li Zefan <lizf@...fujitsu.com> wrote:
>
>> This control file is the equivalent of the "tasks" control file, but
>> acting/reporting on entire thread groups.
>>
>> For example, we have a process with pid 1000 and its sub-thread with
>> tid 1001, to attach them into a cgroup:
>> # echo 1000 > procs
>> Then show the process list and the task list respectively:
>> # cat procs
>> 1000
>> # cat tasks
>> 1000
>> 1001
>>
>> Questions:
>> - What to do if the attaching of a thread failed? continue to attach
>> other threads, or stop and return error?
>> - When a sub-thread of a process is in the cgroup, but not its thread
>> cgroup leader, what to do when 'cat procs'? just skip those threads?
>>
> I think this feature make sense. But not meets a theory that cgroup handles
> a thread not a process. So, how about changing the definition of this interface
> from
> - showing procs
> to
> - showing threads which is thread-group-leader.
>
> One possible problem is a case that thread-group-leader exits while other
> members are alive. In such case, thread-group-leader calls cgroup_exit()
> but will be still alive until all sub-threads exit. So, this interface
> cannot show correct information.
> (right ??? please point out if I miss something)
>
It can show the thread group leader in zombie state with [TID]?
> So, how about this kind of interface ? showing both of TID and PID.
>
> %/cat/procs
> TID PID
> 1001 1001
> 1234 1001
> 3856 1001
> 728 728
> ....
> ....
>
> nonsense ?
This information is also available from other means /proc/pid/tasks for example.
I like Li's original interface for procs and tasks. I would also suggest adding
groups.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists