linux-kernel - Re: [PATCH] Unify crashkernel reservation for 32 and 64 bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080620143717.GH8135@elte.hu>
Date:	Fri, 20 Jun 2008 16:37:17 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Bernhard Walle <bwalle@...e.de>
Cc:	linux-kernel@...r.kernel.org, yhlu.kernel@...il.com,
	the arch/x86 maintainers <x86@...nel.org>
Subject: Re: [PATCH] Unify crashkernel reservation for 32 and 64 bit


* Bernhard Walle <bwalle@...e.de> wrote:

> > famous last words :)
> > 
> > can you see any functionality difference between them? If yes, that 
> > should be declared.
> 
> The only difference was the calculation of memory -- it's more 
> complicated on i386 because of high memory support, so that was 
> outsourced to an inline function. However, because the highmem is in
> 
>   #ifdef CONFIG_HIGHMEM
>   #endif
> 
> and CONFIG_HIGHMEM is off on x86-64, that doesn't matter. Do you see 
> another issue?

i can see no issue, i was just was confused a bit by the "more or less" 
qualifier.

I've applied your patch to tip/x86/mpparse, thanks Bernhard.

> I tested it on both x86-64 and i386, with CONFIG_KEXEC on and off (so 
> that it compiles).

that's always good to know - it's useful to know the amount and scope of 
testing - i've put this into the changelog.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/