linux-kernel - Re: MMC: card test driver should not be builtin with other card support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080620110115.GB21835@fluff.org.uk>
Date:	Fri, 20 Jun 2008 12:01:15 +0100
From:	Ben Dooks <ben-linux@...ff.org>
To:	linux-kernel@...r.kernel.org
Cc:	drzeus-mmc@...eus.cx, Ben Dooks <ben-linux@...ff.org>
Subject: Re: MMC: card test driver should not be builtin with other card
	support

On Fri, Jun 20, 2008 at 11:58:02AM +0100, ben@...ff.org.uk wrote:
> The mmc test driver and mmc block driver will attempt to bind
> to any card present in the system, which means only one of these
> drivers will end up with the card. If either one of these is selected
> as builtin, ensure the other does not get built.
> 
> Signed-off-by: Ben Dooks <ben-linux@...ff.org>
> 
> Index: linux-2.6.26-rc6-sdmmc3/drivers/mmc/card/Kconfig
> ===================================================================
> --- linux-2.6.26-rc6-sdmmc3.orig/drivers/mmc/card/Kconfig	2008-06-20 11:53:08.000000000 +0100
> +++ linux-2.6.26-rc6-sdmmc3/drivers/mmc/card/Kconfig	2008-06-20 11:53:29.000000000 +0100
> @@ -6,7 +6,7 @@ comment "MMC/SD Card Drivers"
>  
>  config MMC_BLOCK
>  	tristate "MMC block device driver"
> -	depends on BLOCK
> +	depends on BLOCK && MMC_TEST != y
>  	default y
>  	help
>  	  Say Y here to enable the MMC block device driver support.
> @@ -42,6 +42,7 @@ config SDIO_UART
>  config MMC_TEST
>  	tristate "MMC host test driver"
>  	default n
> +	depends on MMC_BLOCK != y
>  	help
>  	  Development driver that performs a series of reads and writes
>  	  to a memory card in order to expose certain well known bugs

This is what I would have liked to have done in Kconfig, but of course
the system fails with a circular dependency error. Is there any way
to get this done without some horrible hacks?

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/