linux-kernel - Re: Scatter-gather list constraints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <485D1C67.7050907@firstfloor.org>
Date:	Sat, 21 Jun 2008 17:21:11 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Kernel development list <linux-kernel@...r.kernel.org>,
	AntonioLin <antonio.lin@...ormicro.com>,
	David Vrabel <david.vrabel@....com>
Subject: Re: Scatter-gather list constraints

Alan Stern wrote:
> On Sat, 21 Jun 2008, Andi Kleen wrote:
> 
>> Alan Stern <stern@...land.harvard.edu> writes:
>>
>>> This question arises in connection with wireless USB mass-storage
>>> devices.  The controller driver requires that all DMA segments
>>> in a transfer, other than the last one, have a multiple of 1024 bytes.  
>>> But we're sometimes getting s-g lists where an element contains an odd
>>> number of 512-byte sectors, and of course it doesn't work.
>> But you can handle a single 512 byte request?
> 
> Yes.  And we can handle a list containing a bunch of 1024-byte segments
> terminated by a single 512-byte segment.
> 
>> Splitting the request
>> in this case should work. Or maybe copying is cheaper than splitting?
> 
> Splitting would work.  But it has to be done fairly high up in the 
> stack, ideally in the block layer.

That's true. Or you would need to reserve requests for this, which is likely
a bad idea. Perhaps you're better off just copying in this (hopefully
rare) case. Fortunately lately thanks to work from Peter Z. allocating memory
in the write out path is much safer than it used to be.

Also for my edification: is that a general restriction of the wireless usb
spec or just a specific hardware quirk in some design?

> 
>> I don't think the block layer knows about such kinds of restrictions.
> 
> Evidently not.  Is it feasible to add such knowledge to the block
> layer?

You would need to ask Jens, but I would assume he would ask:
- Is it common?
- Is it performance critical?
and presumably the answer to both would be "no" ?

-Andi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/