linux-kernel - Re: [PATCH] alpha: resurrect Cypress IDE quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200806212045.12982.bzolnier@gmail.com>
Date:	Sat, 21 Jun 2008 20:45:11 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Ivan Kokshaysky <ink@...assic.park.msu.ru>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Richard Henderson <rth@...ddle.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] alpha: resurrect Cypress IDE quirk

On Saturday 21 June 2008, Ivan Kokshaysky wrote:
> Which was removed in the hope that generic legacy IDE quirk in
> drivers/pci/probe.c is sufficient for Cypress IDE.
> It isn't, as this controller has non-standard BAR layout:
> secondary channel registers are in the BAR0-1 of the second
> PCI function - not in the BAR2-3 of the same function, as the
> generic quirk routine assumes.
> 
> Signed-off-by: Ivan Kokshaysky <ink@...assic.park.msu.ru>

ACK, thanks for fixing it.

This actually reminds me that we should probably limit cy82c693
driver to be selectable only on alpha (I've never seen this chipset
being used on anything else + quick googling for non-alpha dmesgs
seems to confirm it)?

From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Subject: [PATCH] ide: limit cy82c693 host driver to ALPHA

Cc: Ivan Kokshaysky <ink@...assic.park.msu.ru>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
---
 drivers/ide/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Index: b/drivers/ide/Kconfig
===================================================================
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -510,6 +510,7 @@ config BLK_DEV_TRIFLEX
 
 config BLK_DEV_CY82C693
 	tristate "CY82C693 chipset support"
+	depends on ALPHA
 	select IDE_TIMINGS
 	select BLK_DEV_IDEDMA_PCI
 	help
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/