linux-kernel - Re: [PATCH 12/18] ide: use ->tf_load in actual_try_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806212110.31086.bzolnier@gmail.com>
Date:	Sat, 21 Jun 2008 21:10:30 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/18] ide: use ->tf_load in actual_try_to_identify()

On Saturday 21 June 2008, Sergei Shtylyov wrote:
> Hello.
> 
> Bartlomiej Zolnierkiewicz wrote:
> > Convert actual_try_to_identify() to use ->tf_load instead of ->OUTB.
> >
> > There should be no functional changes caused by this patch.
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> >   
> [...]
> > Index: b/drivers/ide/ide-probe.c
> > ===================================================================
> > --- a/drivers/ide/ide-probe.c
> > +++ b/drivers/ide/ide-probe.c
> > @@ -290,9 +290,15 @@ static int actual_try_to_identify (ide_d
> >  	/* set features register for atapi
> >  	 * identify command to be sure of reply
> >  	 */
> > -	if ((cmd == WIN_PIDENTIFY))
> > -		/* disable dma & overlap */
> > -		hwif->OUTB(0, io_ports->feature_addr);
> > +	if (cmd == WIN_PIDENTIFY) {
> > +		ide_task_t task;
> > +
> > +		memset(&task, 0, sizeof(task));
> > +		/* disable DMA & overlap */
> > +		task.tf_flags = IDE_TFLAG_OUT_FEATURE;
> > +
> > +		drive->hwif->tf_load(drive, &task);
> > +	}
> >   
> 
>    Eww, this is bulky but should be a part of your plan to switch to 
> tf_load() method...

Yes on both matters:

- It is a part of The Grand Plan. ;)

- I also don't like the small increase of complexity but these changes
  make the core code completely independent of the hardware I/O registers
  (allowing any taskfile transport method).

PS Thanks for reviewing these patches.

Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/