linux-kernel - Re: Linux 2.6.26-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0806220926150.2926@woody.linux-foundation.org>
Date:	Sun, 22 Jun 2008 09:29:35 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jeff Chua <jeff.chua.linux@...il.com>
cc:	ecollins@...are.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	support@...are.com
Subject: Re: Linux 2.6.26-rc7



On Sun, 22 Jun 2008, Jeff Chua wrote:

> On Sat, Jun 21, 2008 at 7:42 AM, Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
> > Another week, another -rc.
> > Linus Torvalds (4):
> >      Reinstate ZERO_PAGE optimization in 'get_user_pages()' and fix XIP
> 
> [89f5b7da2a6bad2e84670422ab8192382a5aeb9f]
> 
> This broke vmware 6.0.4.

Hmm. Can you see which part of it broke? Was it the "fix XIP" part ot the 
ZERO_PAGE part? The easiest way to test is to apply this patch, and see 
(it just disables the XIP part of fix)

		Linus
---
 mm/memory.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/mm/memory.c b/mm/memory.c
index 9aefaae..9056132 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1023,8 +1023,12 @@ out:
 	return page;
 
 bad_page:
+#if 0
 	pte_unmap_unlock(ptep, ptl);
 	return ERR_PTR(-EFAULT);
+#else
+	return NULL;
+#endif
 
 no_page:
 	pte_unmap_unlock(ptep, ptl);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/