linux-kernel - oops in Audiowerk2 ALSA driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Jun 2008 18:47:17 +0200
From:	Marcin Slusarz <marcin.slusarz@...il.com>
To:	Cedric Bregardis <cedric.bregardis@...e.fr>,
	Jean-Christian Hassler <jhassler@...e.fr>
Cc:	LKML <linux-kernel@...r.kernel.org>, Takashi Iwai <tiwai@...e.de>
Subject: oops in Audiowerk2 ALSA driver

Hi
There's a race between registration routine and interrupt handler in aw2 driver
which manifested as oops on some box [1].

When snd_aw2_create calls request_irq chip data are not yet fully initialized.
If interrupt raises before snd_aw2_create call snd_aw2_saa7146_setup, driver may
oops or read/write other port than its own. (chip->base_addr is initialized in
snd_aw2_saa7146_setup, but is used in snd_aw2_saa7146_interrupt via READREG/WRITEREG)

The simple fix would be to move call to snd_aw2_saa7146_setup before request_irq,
but snd_aw2_saa7146_setup enables interrupts...

PS: I don't have this hardware.

Marcin

[1] http://kerneloops.org/guilty.php?guilty=snd_aw2_saa7146_interrupt&version=2.6.26-rc&start=1703936&end=1736703&class=oops
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/