linux-kernel - Re: [lm-sensors] [REGRESSION, ABI] Re: LMSENSORS: 2.6.26-rc, enabling ACPI Termal Zone support costs sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <485E6F12.4010307@keyaccess.nl>
Date:	Sun, 22 Jun 2008 17:26:10 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Hans de Goede <j.w.r.degoede@....nl>
CC:	linux-acpi@...r.kernel.org,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	lm-sensors@...sensors.org,
	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	Zhang Rui <rui.zhang@...el.com>
Subject: Re: [lm-sensors] [REGRESSION, ABI] Re:  LMSENSORS: 2.6.26-rc, enabling
 ACPI Termal Zone support costs sensors

On 22-06-08 16:29, Hans de Goede wrote:

> Rene Herman wrote:
>> This is an ABI breakage issue and an unfortunate one at that:
>>
> 
> No it is not, in 2.6.26rcX, the acpi thermalzones have grown a hwmon 
> interface, that is they register a hwmon device so that "sensors" and

[ ... ]

Now what? Yes it is. 2.6.25.7 works and 2.6.26-rcX with the same config 
options and the same userspace does not. What do you think ABI breakage 
is? It's not relevant that you feel/know that the lm_sensors userspace 
has a bug; it used to work, it's widely installed and the new kernel 
side code however conceptually correct breaks those setups.

>> But if not, .26 is around the corner and requiring libsensors-3.0 must 
>> really not be.
>>
> I agree that requiring libsensors-3.0.2 for this is not a good solution, 
> but I don't want to be crippling the kernel for what I believe is a bug 
> in 2.10.x either.

You don't need to. As said, just make it optional. The attached seems to 
be working for me.

Rene.

View attachment "thermal-hwmon.diff" of type "text/plain" (1125 bytes)