linux-kernel - Re: [linux-pm] [PATCH]ACPI: Fix CMOS time error after waking up by /proc/acpi/alarm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080623091051.GA1917@elf.ucw.cz>
Date:	Mon, 23 Jun 2008 11:10:51 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	"Chen, Huacai" <huacai.chen@...el.com>
Cc:	linux-acpi@...r.kernel.org, linux-pm@...ts.linux-foundation.org,
	lenb@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [linux-pm] [PATCH]ACPI: Fix CMOS time error after waking up by
	/proc/acpi/alarm

On Thu 2008-06-19 21:52:02, Chen, Huacai wrote:
> From: Huacai Chen <huacai.chen@...el.com>
> 
> When writing /proc/acpi/alarm to wakeup up in adjust mode, this patch
> read the "century" filed and add it to the "year" field before writing.
> This avoids the CMOS time error (2000 years decrement) after waking up.
> 
> Signed-off-by: Huacai Chen <huacai.chen@...el.com>

Probably word-wrapped,

> ---
> diff --git a/drivers/acpi/sleep/proc.c b/drivers/acpi/sleep/proc.c
> index 224c57c..2a85783 100644
> --- a/drivers/acpi/sleep/proc.c
> +++ b/drivers/acpi/sleep/proc.c
> @@ -315,8 +315,11 @@ acpi_system_write_alarm(struct file *file,
>  		cmos_bcd_write(day, acpi_gbl_FADT.day_alarm,
> rtc_control);
>  	if (acpi_gbl_FADT.month_alarm)
>  		cmos_bcd_write(mo, acpi_gbl_FADT.month_alarm,
> rtc_control);
> -	if (acpi_gbl_FADT.century)
> +	if (acpi_gbl_FADT.century){

and you definitely want ") {" here.

It probably should go to Len and RTC maintainers?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/