linux-kernel - Re: sata_svw data corruption, strange problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080623092638.GH1850@elf.ucw.cz>
Date:	Mon, 23 Jun 2008 11:26:38 +0200
From:	Pavel Machek <pavel@...e.cz>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Tejun Heo <tj@...nel.org>, Andreas Schwab <schwab@...e.de>,
	kernel list <linux-kernel@...r.kernel.org>, jgarzik@...ox.com,
	IDE/ATA development list <linux-ide@...r.kernel.org>,
	Trivial patch monkey <trivial@...nel.org>
Subject: Re: sata_svw data corruption, strange problems

On Mon 2008-06-23 19:04:19, Benjamin Herrenschmidt wrote:
> On Mon, 2008-06-23 at 11:01 +0200, Pavel Machek wrote:
> > On Mon 2008-06-23 17:56:32, Tejun Heo wrote:
> > > Pavel Machek wrote:
> > > > On Mon 2008-06-23 10:39:40, Andreas Schwab wrote:
> > > >> Pavel Machek <pavel@...e.cz> writes:
> > > >>
> > > >>> +	   controller, the controller could hang. In other cases it
> > > >>> +	   could return partial data returning in data
> > > >>> +	   corruption. This problem has been seen in PPC systems and
> > > >> s/returning/resulting/ ?
> > > > 
> > > > Fix thinko in sata_svw comment.
> > > > 
> > > > Signed-off-by: Pavel Machek <pavel@...e.cz>
> > > 
> > > Please collapse into one patch.  Thanks.
> 
> Am I the only one to find Pavel variant almost as obscure as
> the original one ? :-)

At least it makes it clear that the bug should not bite in new
releases.

I'm neither native english speaker nor author of this driver, so if
you'd like to improve the comment, please do so. (I spent quite long
time wondering if we do workaround that hw problem or not, that's why
I'm trying to clarify the comment).
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/