linux-kernel - Re: [PATCH] dabusb: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080623112004.GA26516@infradead.org>
Date:	Mon, 23 Jun 2008 07:20:04 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Deti Fliegl <deti@...egl.de>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-kernel@...r.kernel.org, jaswinder@...radead.org
Subject: Re: [PATCH] dabusb: use request_firmware()

> +config USB_DABUSB_FIRMWARE
> +	bool "Include firmware images for DABUSB driver"
> +	depends on USB_DABUSB
> +	---help---
> +	Include the firmware for the DABUSB device in the kernel image.
> +	Say 'N' and let it get loaded from userspace.

Sorry if I missed a discussion on it in the intial firmware threads, but
what is the point of all these FOO_FIRMWARE options?  I think we should
include all firmware that we have a driver for if people want firmware
built-in and non if not.

That is instead of all these FOO_FIRMWARE options just have one
user-visible BUILTIN_FIRMWARE option.  Also makes it much less likely
for mingo to accidentally build a kernel image that doesn't actually boot :)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/