linux-kernel - Re: LMSENSORS: 2.6.26-rc, enabling ACPI Termal Zone support costs sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080623135704.2980078c@hyperion.delvare>
Date:	Mon, 23 Jun 2008 13:57:04 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Rene Herman <rene.herman@...access.nl>
Cc:	Hans de Goede <j.w.r.degoede@....nl>, linux-acpi@...r.kernel.org,
	Zhang Rui <rui.zhang@...el.com>,
	"Mark M. Hoffman" <mhoffman@...htlink.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	lm-sensors@...sensors.org
Subject: Re: LMSENSORS: 2.6.26-rc,  enabling ACPI Termal Zone support costs
  sensors

Hi Rene,

On Mon, 23 Jun 2008 12:24:06 +0200, Rene Herman wrote:
> On 23-06-08 12:08, Jean Delvare wrote:
> > No, the kernel does the right thing and does not need to be modified
> > at all.
> 
> No Jean, this is totally unacceptable. No matter how you want to call 
> things, 2.6.26 is going to break important functionality on millions of 
> systems and you simply do not get to do that.

No, it's not going to be the end of the world that you predict. Please
stop being alarmist, it really doesn't help.

We are going to break hardware monitoring for users who upgrade to
kernel 2.6.26 by themselves and have enabled option "THERMAL" and are
using lm-sensors <= 2.10.6. I suspect this is a relatively small number
of users, and these are also the ones who are presumably skilled enough
to go to http://www.lm-sensors.org/, find the patch they need, and
apply it to libsensors themselves. 

We are not going to break any system using a distribution kernel
because distributions test their kernel at least to some extent before
they release it, and that kind of breakage can't go unnoticed. So,
distributions which haven't completely switched to lm-sensors 3.x yet,
will see the breakage and patch their libsensors 2.10.6 to fix it. For
what it's worth, the patch in question is in openSuse since March 17th.

For distributions who have good maintainers, there should never be any
problem anyway. We maintain and publish a list of recommended patches.
A distribution with all these patches applied should avoid all known
problems, compatibility or otherwise.

Please also realize that I personally keep the maintainers of the
Fedora, openSuse and Debian lm-sensors packages informed when I update
the list of recommended patches. If I should forget to do so and they
hit a problem, they know where to find me.

> Can you comment on the last patch posted? It's trivial:
> 
> http://lkml.org/lkml/2008/6/22/243

It's trivial and wrong, so thanks but no thanks. The bug is in
libsensors, we fix it in libsensors.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/