linux-kernel - [PATCH 0/2]v2 configfs: symlink() fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1214223378-14203-1-git-send-email-louis.rilling@kerlabs.com>
Date:	Mon, 23 Jun 2008 14:16:16 +0200
From:	Louis Rilling <louis.rilling@...labs.com>
To:	Joel.Becker@...cle.com
Cc:	linux-kernel@...r.kernel.org, ocfs2-devel@....oracle.com,
	Louis Rilling <louis.rilling@...labs.com>
Subject: [PATCH 0/2]v2 configfs: symlink() fixes

[ applies on top of the previously submitted rename() vs rmdir() deadlock fix ]

Hi,

The following patchset fixes incorrect symlinks to dead items in configfs, which
are forbidden by specification.

The first patch actually prevents such dangling symlinks from being created, but
introduces a weird(?) behavior where a failing symlink() can make a racing
rmdir() fail in the symlink's parent and in the symlink's target as well. This
behavior is fixed with the next patch.

Changelog:
  - fix error code when symlink's target is being removed
  - re-implemented the weird(?) behavior fix in a way that does not temporarily
    instantiate the new symlink in the VFS.

Summary:
  configfs: Fix symlink() to a removing item
  configfs: Fix failing symlink() making rmdir() fail

 fs/configfs/configfs_internal.h |    1 +
 fs/configfs/dir.c               |   24 +++++++++++++++++-------
 fs/configfs/symlink.c           |   14 +++++++++++++-
 3 files changed, 31 insertions(+), 8 deletions(-)

-- 
Dr Louis Rilling			Kerlabs
Skype: louis.rilling			Batiment Germanium
Phone: (+33|0) 6 80 89 08 23		80 avenue des Buttes de Coesmes
http://www.kerlabs.com/			35700 Rennes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/