linux-kernel - Re: [PATCH] cpia2: use request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080623091631.1e80a784@gaivota>
Date:	Mon, 23 Jun 2008 09:16:31 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	steve.miller@...com, jaswinder@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpia2: use request_firmware()

Hi David,

On Mon, 23 Jun 2008 12:03:33 +0100
David Woodhouse <dwmw2@...radead.org> wrote:

> diff --git a/drivers/media/video/cpia2/Kconfig b/drivers/media/video/cpia2/Kconfig
> index e39a961..64d9866 100644
> --- a/drivers/media/video/cpia2/Kconfig
> +++ b/drivers/media/video/cpia2/Kconfig
> @@ -1,9 +1,17 @@
>  config VIDEO_CPIA2
>  	tristate "CPiA2 Video For Linux"
>  	depends on VIDEO_DEV && USB && VIDEO_V4L1
> +	select FW_LOADER

Since select doesn't check for dependencies, on all places you select
FW_LOADER, you also need to add "depends on HOTPLUG" since FW_LOADER is
defined as(at drivers/base/Kconfig):

config FW_LOADER
        tristate "Userspace firmware loading support"
        depends on HOTPLUG

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/