linux-kernel - Re: [PATCH 01/70] tty: Ldisc revamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080623133912.GU30804@localhost>
Date:	Mon, 23 Jun 2008 15:39:12 +0200
From:	Louis Rilling <Louis.Rilling@...labs.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/70] tty: Ldisc revamp

On Fri, Jun 20, 2008 at 08:58:05PM +0100, Alan Cox wrote:
> From: Alan Cox <alan@...hat.com>
> 
> Move the line disciplines towards a conventional ->ops arrangement. For the
> moment the actual 'tty_ldisc' struct in the tty is kept as part of the tty
> struct but this can then be changed if it turns out that when it all settles
> down we want to refcount ldiscs separately to the tty.
> 
> Pull the ldisc code out of /proc and put it with our ldisc code.
> 

[...]

> diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c
> index e94bee0..ab1dd0a 100644
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c

[...]

> @@ -1386,7 +1467,7 @@ static void tty_reset_termios(struct tty_struct *tty)
>   *	do_tty_hangup		-	actual handler for hangup events
>   *	@work: tty device
>   *
> - *	This can be called by the "eventd" kernel thread.  That is process
> +k *	This can be called by the "eventd" kernel thread.  That is process
>   *	synchronous but doesn't hold any locks, so we need to make sure we
>   *	have the appropriate locks for what we're doing.
>   *

Sorry for such a trivial comment, but the leading 'k' above looks like a typo.

Louis

-- 
Dr Louis Rilling			Kerlabs
Skype: louis.rilling			Batiment Germanium
Phone: (+33|0) 6 80 89 08 23		80 avenue des Buttes de Coesmes
http://www.kerlabs.com/			35700 Rennes

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)