linux-kernel - Re: [patch 05/19] perfmon2 minimal v2: X86 generic code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080624021120.2bcca593.sfr@canb.auug.org.au>
Date:	Tue, 24 Jun 2008 02:11:20 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	eranian@...glemail.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch 05/19] perfmon2 minimal v2:  X86 generic code

Hi Stephane,

On Tue, 17 Jun 2008 15:02:22 -0700 (PDT) eranian@...glemail.com wrote:
>
> This patch adds the X86 generic perfmon2 code. It is in charge of
> implementing certain key functionalities required by the generic
> code such as read/write of the PMU registers, low-level interrupt
> handling.

After applying patches 1-5, building an x86_64 allmodconfig produces
these errors:

In file included from include/linux/perfmon_kern.h:167,
                 from arch/x86/perfmon/perfmon.c:25:
include/linux/perfmon_pmu.h:92: warning: ‘struct pfarg_pmc’ declared inside parameter list
include/linux/perfmon_pmu.h:92: warning: its scope is only this definition or declaration, which is probably not what you want
include/linux/perfmon_pmu.h:96: warning: ‘struct pfarg_pmd’ declared inside parameter list

Those structures aren't defined until patch 11.

In file included from arch/x86/perfmon/perfmon.c:25:
include/linux/perfmon_kern.h: In function ‘pfm_copy_thread’:
include/linux/perfmon_kern.h:199: error: ‘TIF_PERFMON_CTXSW’ undeclared (first use in this function)
arch/x86/perfmon/perfmon.c: In function ‘smp_pmu_interrupt’:
arch/x86/perfmon/perfmon.c:338: error: ‘LOCAL_PERFMON_VECTOR’ undeclared (first use in this function)
arch/x86/perfmon/perfmon.c: In function ‘pfm_arch_resend_irq’:
arch/x86/perfmon/perfmon.c:451: error: ‘LOCAL_PERFMON_VECTOR’ undeclared (first use in this function)
arch/x86/perfmon/perfmon.c: In function ‘pfm_arch_pmu_acquire_percpu’:
arch/x86/perfmon/perfmon.c:475: error: ‘LOCAL_PERFMON_VECTOR’ undeclared (first use in this function)

These are not defined until patch 7.

So I think some rearrangement is still required.

Also, some of the x86 files that you are modifying have had their 32 and
64 bit versions combined in linux-next (which is the stuff of the next
merge window) so just a heads up that there will be more merge work then.
Lastly, some of this will clash with the generic IPIs work.

I don't want to put you off, you have done great work here, thanks.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped