linux-kernel - Re: [PATCH] x86: cleanup using max_low

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86802c440806231327u74d67b59je7f5b42ae1e2b49d@mail.gmail.com>
Date:	Mon, 23 Jun 2008 13:27:39 -0700
From:	"Yinghai Lu" <yhlu.kernel@...il.com>
To:	"Ingo Molnar" <mingo@...e.hu>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: cleanup using max_low_pfn for 32 bit

On Mon, Jun 23, 2008 at 1:22 PM, Ingo Molnar <mingo@...e.hu> wrote:
>
>>       x86: clean up using max_low_pfn on 32-bit
>
> this one needed the small fix below.
>
>        Ingo
>
> ----------->
> commit 749cffb6c81f6637bbd054a4db246196eaa69ccc
> Author: Ingo Molnar <mingo@...e.hu>
> Date:   Mon Jun 23 22:19:22 2008 +0200
>
>    x86: build fix
>
>    fix:
>
>    arch/x86/kernel/setup_32.c:409: error: 'enable_local_apic' undeclared (first use in this function)
>    arch/x86/kernel/setup_32.c:409: error: (Each undeclared identifier is reported only once
>    arch/x86/kernel/setup_32.c:409: error: for each function it appears in.)
>
>    Signed-off-by: Ingo Molnar <mingo@...e.hu>
>
> diff --git a/arch/x86/kernel/setup_32.c b/arch/x86/kernel/setup_32.c
> index b42f570..1e67037 100644
> --- a/arch/x86/kernel/setup_32.c
> +++ b/arch/x86/kernel/setup_32.c
> @@ -406,7 +406,9 @@ void __init setup_arch(char **cmdline_p)
>        parse_early_param();
>
>        if (acpi_mps_check()){
> +#ifdef CONFIG_X86_LOCAL_APIC
>                enable_local_apic = -1;
> +#endif
>                clear_cpu_cap(&boot_cpu_data, X86_FEATURE_APIC);
>        }

need to merge enable_local_apic (32bit) and disable_apic (64 bit).

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/