lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jun 2008 15:34:09 -0500 From: Eric Sandeen <sandeen@...hat.com> To: Andreas Dilger <adilger@....com> CC: FD Cami <francois.cami@...e.fr>, linux-kernel@...r.kernel.org, linux-ext4@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Kasper Sandberg <lkml@...anurb.dk> Subject: Re: [PATCH] extX: convert prink(KERN_WARNING) to extX_warning() Andreas Dilger wrote: > On Jun 22, 2008 20:18 +0200, FD Cami wrote: >> This patch takes a shot at replacing the direct use of printk(KERN_WARNING) >> in extX by extX_warning. We now get the device number in the warning message : >> "EXT3-fs warning (device hda1): ext3_setup_super: maximal mount count reached, running e2fsck is recommended" >> It also adds the device information on a pair of printk(KERN_ERR) (this was >> first suggested by Kasper two weeks ago). > > The one issue is that KERN_ERR != KERN_WARNING, so these errors might > not be visible on the console, or may not be saved to the syslog. The > other minor difference is that the function name is also printed, and this > makes the error message very long. > > One suggestion is to create a separate macro that passes the KERN_* > flag and __func__ to ext3_console_msg(), and call that from > ext3_warning() and a new ext3_start_error() function. I always found > it annoying to have to specify __func__ as a parameter for every call. I agree and meant to suggest that as well. -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists