[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20080623211335.GA12877@elte.hu>
Date: Mon, 23 Jun 2008 23:13:35 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Cliff Wickman <cpw@....com>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] SGI UV: uv_ptc_proc_write security hole
* Cliff Wickman <cpw@....com> wrote:
> From: Cliff Wickman <cpw@....com>
>
> Someone could write 0 bytes to /proc/sgi_uv/ptc_statistics,
> causing
> optstr[count - 1] = '\0';
> to write to who-knows-where.
>
> (Andi Kleen noticed this need from a patch I sent for
> similar code in the ia64 world (sn2_ptc_proc_write()).)
>
> (count less than zero is not possible here, as count is unsigned)
>
> Diffed against 2.6.26-rc6
applied to tip/x86/uv - thanks Cliff.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists