linux-kernel - Re: [RFC PATCH] x86:Use cpu_khz for loops_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080623234728.GA17297@elte.hu>
Date:	Tue, 24 Jun 2008 01:47:28 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alok Kataria <akataria@...are.com>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	Daniel Hecht <dhecht@...are.com>, Tim Mann <mann@...are.com>,
	Zach Amsden <zach@...are.com>, Sahil Rihan <srihan@...are.com>
Subject: Re: [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation


* Alok Kataria <akataria@...are.com> wrote:

> > but there's another problem as well: why are generic files 
> > (init/calibrate.c and include/linux/delay.h) using something that is 
> > named in an x86-specific way - lpj_tsc ? (TSC is an x86 concept)
> 
> calibrate_delay_direct was using some variables with "tsc" as the 
> prefix (tsc_rate_min/max) ...so i thought of using lpj_tsc. And also 
> IMO, lpj_tsc explains how is this variable initialized. But thinking 
> about it, maybe we should rename it to "lpj_timer" ?

ok. But instead of 'lpj_timer' i'd suggest to use something like 
'lpj_fine' - as this really is about finegrained measurements.

I'd suggest a delta patch against tip/master that renames all those 
tsc_* variables to fine_*. So tsc_rate_min would become fine_rate_min, 
etc.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/