linux-kernel - Re: [patch 2.6.26-rc7] <linux/bcd.h> space reduction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200806230015.49973.david-b@pacbell.net>
Date:	Mon, 23 Jun 2008 00:15:49 -0700
From:	David Brownell <david-b@...bell.net>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	lkml <linux-kernel@...r.kernel.org>, rtc-linux@...glegroups.com
Subject: Re: [patch 2.6.26-rc7] <linux/bcd.h> space reduction

On Sunday 22 June 2008, Adrian Bunk wrote:
> On Sun, Jun 22, 2008 at 07:54:36PM -0700, David Brownell wrote:
> > This updates <linux/bcd.h> to define the key routines as static
> > constant functions, which the macros will then call.
> > 
> > 	... Typical per-driver savings top 200 bytes. ...
> 
> The patch breaks the compilation:

Needs to #include <linux/types.h> then; "u8" isn't always known.
Or maybe just spell it out "unsigned char".


>	...
> 
> Additionally, I'd suggest to make them out-of-line functions 
> instead of shipping multiple copies in different object files.

That was one of the options.  I thought I'd start with something
simpler, and see what folk thought.

Where would that be ... lib/bcd.c, always linked?  And if it goes
that way I'd prefer bcd2bin() and bin2bcd(), not these names.  A
small impetus to have LESS SOURCE CODE SHOUTING AT ME.

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/