lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 Jun 2008 09:47:53 +0200 From: Elias Oltmanns <eo@...ensachen.de> To: Bartlomiej Zolnierkiewicz <bzolnier@...il.com> Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, Randy Dunlap <randy.dunlap@...cle.com> Subject: Re: [PATCH] IDE: Fix HDIO_DRIVE_RESET handling Elias Oltmanns <eo@...ensachen.de> wrote: [...] > @@ -941,6 +949,7 @@ static ide_startstop_t atapi_reset_pollfunc (ide_drive_t *drive) > /* done polling */ > hwgroup->polling = 0; > hwgroup->resetting = 0; Actually, ->resetting needs to be protected by the ide_lock here. [...] > @@ -1005,6 +1014,8 @@ static ide_startstop_t reset_pollfunc (ide_drive_t *drive) > } > hwgroup->polling = 0; /* done polling */ > hwgroup->resetting = 0; /* done reset attempt */ Same as above. Unless I have missed something, a simple spin_lock(&ide_lock) should suffice since there cannot possibly be another interrupt that changes ->resetting behind our back. I'll send an updated version of patches 1 and 4 once I have your opinion on the current series. Regards, Elias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists